search

USEPA / useeio-widgets

Creative Commons Zero v1.0 Universal
3 stars 17 forks source link

10. Exclude JOBS and VADD from default sort #35

Closed TheTisiboth closed 3 years ago

TheTisiboth commented 3 years ago
  1. I can't tell if the positive indicators JOBS and VADD are already excluded from the default sort. If they are not yet, let's consider adding a javascript parameter to exclude "JOBS,VADD" from the default combined sort that occurs when no other indicators are selected. Another approach would be to flag them as positive elsewhere in the code or API.

With either approach, let's continue to show the positive columns, but display a note below the charts when a combined sort occurs in which they are excluded. Something like: "The positive indicators JOBS and VADD are excluded from the combined sort. This allows the most adverse overall impacts to appear first."

The following showvalues chart is a good place to review the items below: https://thetisiboth.github.io/useeio-widget-builds/sector_list.html#view=mosaic&showvalues=true

TheTisiboth commented 3 years ago

I did it, but I am not sure if it changes a lot of things about the displayed sectors