search

USEPA / useeior

Estimating potential environmental impacts of goods and services in the US economy
MIT License
31 stars 19 forks source link

Correct output ratio calculation for Summary and Sector level models #237

Closed MoLi7 closed 2 years ago

MoLi7 commented 2 years ago

This PR addresses issue #236

MoLi7 commented 2 years ago

Created this PR to assist inspection to understand the full impact of issue #236 . Will decide whether to merge it with master for a patch release or not. @WesIngwersen

MoLi7 commented 2 years ago

Made a few more commits to

  1. ensure order of margin sectors are consistent across tables
  2. ensure all transportation sectors are correctly marked in schema info tables

Now the issue is resolved, and this PR is ready to be merged to master.

Regarding the new release, I propose that we version it v1.1.1 and label it SEF_v1.1.2 because updates in this release mainly affect the supply chain EF calculations. @WesIngwersen

WesIngwersen commented 2 years ago

Thanks but lets not put SEF in the tag because we dont have a planned SEF release to match