USFS-PNW / Fia-Biosum-Manager

User interface and main code repository for Biosum
http://biosum.info/
Other
3 stars 3 forks source link

FVS: Pre-audit reports grow-only packages as failures #188

Open lbross opened 5 years ago

lbross commented 5 years ago

When a grow only package is included in the FVS output list of packages to process (as it must be), it generates a “FAILED AUDIT” message in the audit results dialog—not ideal behavior. In this example, the third package evaluated was CEC 031 (grow only). BioSum is producing this failed audit message because there are no cutlist trees, but the rest of the FVS output tables must nonetheless be processed to generate the material needed for Treatment Optimizer effectiveness determination when using grow-only as a baseline.

Moreover, the dialog does not report results for package 31 (grow only)—just produces the Failed Audit message, but does not announce which variant and package has failed. If you were auditing many packages in a batch, you would have to open a lot of audit logs to figure out which one failed, and if it was a grow-only package or a package that really failed.

The reason for the failure given in the audit log is: -----FVS_CUTLIST----- ERROR: No trees in fvs_cutlist table

For a grow-only case, this is expected (that there will be no trees in the cutlist). Do we handle this through documentation (informing the user to expect the audit fail for this case) or change this diagnosis (of no cut list trees) to a warning?

Need confirmation this is pre-audit.

image

lbross commented 3 years ago

Another issue from @jsfried with the FVS Pre-audit: For the tree table, the audit should filter out simulation years that don’t match years in Summary. These will apparently appear for tree records in stands with no live trees. I don’t see these in the CEC project but I do see this going on in the full Blue Mountains 12 project (with years of 580 and 581). If a tree record year is > the max year in the summary table records, I think those tree records are safe to ignore in the audit processing.