search

USFS-PNW / Fia-Biosum-Manager

User interface and main code repository for Biosum
http://biosum.info/
Other
3 stars 3 forks source link

FVS: SeqNum Assignment instability and more tables need POTFIRE option and Clarification needed around package selection #207

Open jsfried opened 5 years ago

jsfried commented 5 years ago

Two issues identified in the sequence number specification (for PRE POST assignment in the FVS OUTPUT LOAD workflow):

  1. Other tables besides POTFIRE require base year handling, including CARBON and HRV_CARBON. They report values AFTER treatments are implemented so that one cannot get a PRE-treatment value of any of the attributes in those tables without going the BASEYR route that we went with POTFIRE. For existing projects where we want to use these tables in optimizer, we'll need to rerun the BASEYEAR kcp file to generate base year versions for these tables (the output for 1 year with no treatment). While that is easy enough to do, there is no way to load these BASEYEAR tables into BioSum because the checkbox that allows selection of a base year is only provided for the POTFIRE table, NOT any of the other tables. I think we should not restrict the use of this checkbox- make it available for every table and the user can be responsible for knowing whether or not it is needed- I know I don't want to be responsible for this, as FVS can be an ever changing beast.
  2. There seems to be an option to choose particular packages to assign seqnums to. If one chooses this and specifies the packages, then later decides not to specify particular packages but go back to the default (I presume) of having the assignments made for all packages, we end up with a blank in the Packages field (if successful in saving this change) or we get an unhandled exception error when we are not successful (see below). SEQNUM_ASSIGN_ERROR
jsfried commented 5 years ago

Inadvertently closed. Meant to open.

lbross commented 5 years ago

From @jsfried: if we are going to limit the base year box to certain tables, we need to farm out to someone the responsibility of which tables those are

lbross commented 4 years ago

Move access to sequence number screen to a separate button on the main FVS menu as it affects all variant/packages. We will remove the option from the dropdown menu on FVS In when the new screen is ready for deployment

lbross commented 3 years ago

There is currently no help text associated with the sequence number screens. This needs to be addressed, likely by @jsfried, as part of the sequence number redesign. The current screens could also be documented if we think the redesign is a ways off. Setting up and changing the help text for a screen requires minimal development effort. The time commitment is in writing the help.

sebbusby commented 2 years ago

@lbross I'm not quite sure how to validate issue #207, or whether it needs validation given planned changes to the SeqNum interface. Let me know your thoughts/suggestions.

lbross commented 2 years ago

@sebbusby This is a fix for a bug I encountered while learning the sequence number interface. If you create a custom sequence number assignment (without assigned rxPackages), save it, and then try to modify it, it should give you a warning that you need to have rxPackages assigned. I put this in because if you followed these steps in v5.9, it would cause BioSum to crash. You are correct that this issue should not be closed because of the planned changes to the SeqNum interface. That being said, it would be nice to make sure this small fix is working as intended.

sebbusby commented 2 years ago

@lbross Thanks for the specific validation instructions Lesley, your fix is working properly :).