USFS-PNW / Fia-Biosum-Manager

User interface and main code repository for Biosum
http://biosum.info/
Other
3 stars 3 forks source link

FVS: Update Sequence Number definition screen with reasonable default and options #282

Closed lbross closed 1 year ago

lbross commented 2 years ago

Set the initial (default) options for the 4 tables to match a pattern that we commonly recommend: 1-8-1 Treat Every Cycle Add this option and 3 additional options to the 'Default SeqNum Options' pick list:

These options are defined in Appendix B of the FIA BIOSUM - Sequence Number Enhancements document.

lbross commented 1 year ago

To assign FFE templates the FVS_POTFIRE table needs to be selected from the list of tables. We realized that this creates a requirement for FVS_POTFIRE in projects that want to use FFE data. We do not want this. We will add an 'FFE' checkbox next to the template picklist to indicate that the FFE sequences should be applied to the selected tables.

jsfried commented 1 year ago

The options in the drop down look good!

jsfried commented 1 year ago

Multi-table assignment (via control click) works. One potential confusion point is that user may think checkbox for POTFIRE might apply to other FFE tables but it can't.

lbross commented 1 year ago

I'm not sure what you mean by 'checkbox for POTFIRE'. Are you talking about the Base Year checkbox? The only way I can think to reliably handle that is to not let POTFIRE be selected with any other tables (like STRCLASS) which removes some of the benefit of the multi-table assignment. But if you think the risk is too big, we can do that.

lbross commented 1 year ago

We will allay @jsfried concern with the Base Year checkbox by preventing FVS_POTFIRE from being selected with any other tables. It will work the same way as FVS_STRCLASS.

sebbusby commented 1 year ago

RE: "Add an FFE checkbox next to the sequence template pick list to support applying POTFIRE sequences to projects that don't have an FVS_POTFIRE table. Restrict FVS_POTFIRE to being assigned by itself because other tables cannot support BaseYr."

Appears to be working properly

lbross commented 1 year ago

From @jsfried:

All the pick list options with BaseYr in their name don’t make sense for any table except for POTFIRE (the only one that baseyr can be implemented). I don’t think it makes any sense to have base yr options showing in the picklist for any table. Better to have only NoBY options (and then you don’t need to label them as NoBY). We can provide instructions for how to mod the Seqnums for a run that does use baseyear for the POTFIRE table.

Please update the 'Seqnums All' tab on the TablesProps.xls with your changes and I will implement them.

What does the list of packages in the packages field signify? Are these packages for which seqnum has been assigned or is it always a list of all packages because we now require that all packages use the same seqnum assignments? If packages were added to the project after seqnums were assigned, would those packages be missing from this list? Perhaps the field should be enlarged and/or be given a scroll bar

The read-only list of packages is always a list of all packages because we now require that all packages use the same seqnum assignments. There is code throughout FVSOut processing that needs the package because it supported sequence number by package. It is not a trivial task to remove this. I haven't decided if I'm going to remove it when transitioning FVSOut to read from SQLite. If packages are added after seqnums were assigned, they would appear on this list because it is always the list of current packages. However, they wouldn't have sequence numbers assigned to them. The sequence number assignments need to be re-saved if new packages are added to update the configuration tables. This isn't ideal but it is lower risk than ripping out the rxpackage references in FVSOut. I believe we discussed adding it to the FVS documentation.

jsfried commented 1 year ago

@lbross Lesley, I have updated the TableProps at https://usfs.box.com/s/ptkovnk4eoicpyzc146ctii0u1bz6s9r to reflect what should be available in the picklists. There are really just 6 sequence number pre-spefications that are needed-- 3 for Summary patterned tables and 3 for FFE patterned tables, in a no base year context (which is going to be the primary supported context-- we can publish the other specs for folks wanting to run BioSum that way-- which they may reasonably wish to do when choosing to use the FIA data completely unperturbed by FVS projection for a 1 time, year 1 treatment operation-- I believe Sam felt that was an important option to preserve and I concur, however, that option does not need to clutter up the pick list for everyone else-- leaving those options out will make BioSum easier to support, I think).

I think that the names in the pick list can be the same for Summary and FFE patterns and only the SEQNUM selections will differ based on whether or not the FFE pattern box is checked.

Thanks for your patience while the options and potential ways forward percolated in my head-- it can be a slow process ;-).

lbross commented 1 year ago

From @jsfried: the pick list and its actions look great