search

USFS-PNW / Fia-Biosum-Manager

User interface and main code repository for Biosum
http://biosum.info/
Other
3 stars 3 forks source link

SETUP: New BioSum_Keywords.kcp for FVS to address SDI and SDIMax anomalies #312

Closed lbross closed 1 month ago

lbross commented 8 months ago

@sebbusby and Dan discovered that FVS misapplies SDI and SDIMax when there are large numbers of seedings/saplings in the input data. This results in unrealistic growth when the simulation runs. This issue can be resolved with directive(s) in the KCP file. @sebbusby will submit an updated BioSum_Keywords.kcp to include with the next .msi.

Do we also want to update the POTFIRE_Keywords.kcp to keep the in sync?

sebbusby commented 8 months ago

@lbross Please find the updated BioSum_Keywords.kcp attached for the next .msi in Box/BioSumBox/Temp30Days/BioSum_Keywords_update_12-15-23.kcp

Didn't we abandon the POTFIRE_Keywords.kcp, or is it still required for using BaseYr with PotFire table? Either way, I don't think it needs any updates, should still work as intended.

lbross commented 8 months ago

After reviewing the deployment configuration, @sebbusby is correct. We are no longer distributing POTFIRE_Keywords.kcp in the application .msi. We have a copy of it stored in GitHub for future reference if needed. This new KCP file is staged and ready to be deployed with the next .msi.

jsfried commented 8 months ago

The potfire keywords file is needed to run base year. I ginned up (by adapting from earlier files) the attached one for the Wallowastart package I added at Lesley's request. It may contain superfluous material. Perhaps Sebastian could check for that and thin it if needed. BioSum_Keywords_BaseYr_POTFIRE.kcp,txt @lbross @sebbusby

sebbusby commented 8 months ago

@lbross @jsfried Did some mild trimming of the BaseYr_POTFIRE.kcp file Jeremy uploaded, please find attached for archiving. BioSum_Keywords_BaseYr_POTFIRE.kcp.txt

lbross commented 8 months ago

OK. The modified POTFIRE script is tucked away in GitHub for safekeeping but is no longer distributed with the .msi to avoid confusion.

lbross commented 1 month ago

From Dan S.: I saw on the validation spreadsheet that issue #312 is still ongoing. I’ve attached the .kcp file to close out that issue here as well.