USFS-PNW / Fia-Biosum-Manager

User interface and main code repository for Biosum
http://biosum.info/
Other
3 stars 3 forks source link

PROCESSOR: The harvest_costs table includes plots with an invalid gis_yard_dist_ft #349

Closed lbross closed 1 week ago

lbross commented 2 months ago

We screen these plots out and do not send them to OpCost. However, they are in the harvest_costs table for two reasons and thus are included in Optimizer analysis when they should not be.

  1. We create placeholder records in the tree vol val and harvest costs table for conditions that don't have cycle 1 activity. There is no filter for gis_yard_dist_ft. We should use the same selection criteria here that we do for sending trees to OpCost.
  2. The kcp additional cpa functionality is another way conditions get added to the harvest_costs table when there is no harvest activity. This algorithm also needs to be adjusted to exclude plots with an invalid gis_yard_dist_ft.
lbross commented 2 months ago

I've added a new RunScenario_DeleteInaccessibleCondFromWorktable() function to prevent plots with yarding distances < 0 from being included in the harvest_costs table.

When the fix is implemented, you will need to re-run Processor before re-running the Optimization scenarios to have this take affect on the Optimization output.

lbross commented 1 week ago

From @Cat-Ducat-USDA: Ran Access query linking plot -> cond -> harvest_costs, filtered where plot.gis_yard_dist_ft = -1... no BioSumCondIDs returned