Closed zednis closed 8 years ago
Since this request is failing, I'm closing #167.
@justgo129 we don't automatically close a pull request just because it is failing as additional commits can be made to the branch to correct the issue, we just don't merge the pull request unless it is passing.
Additionally, it looks like the 'failed test' on this commit was actually on master - which was failing tests at the time.
@zednis I am absolutely fine with your suggested approach. Please note that it differs from what the group did previously -- we closed and then reopened when problems were fixed. I am more than happy to adopt this suggest practice.
@rewolfe if you are all right with the suggested URI shown on Line 21 of the commit, I will merge.
@justgo129 - Looks good.
Merged #167.
resolves #149