search

USGCRP / gcis-ontology

Ontology for the Global Change Information System
4 stars 7 forks source link

updated specified version to 2.0; added owl:versionIRI #167

Closed zednis closed 8 years ago

zednis commented 8 years ago

resolves #149

justgo129 commented 8 years ago

Since this request is failing, I'm closing #167.

zednis commented 8 years ago

@justgo129 we don't automatically close a pull request just because it is failing as additional commits can be made to the branch to correct the issue, we just don't merge the pull request unless it is passing.

zednis commented 8 years ago

Additionally, it looks like the 'failed test' on this commit was actually on master - which was failing tests at the time.

justgo129 commented 8 years ago

@zednis I am absolutely fine with your suggested approach. Please note that it differs from what the group did previously -- we closed and then reopened when problems were fixed. I am more than happy to adopt this suggest practice.

justgo129 commented 8 years ago

@rewolfe if you are all right with the suggested URI shown on Line 21 of the commit, I will merge.

rewolfe commented 8 years ago

@justgo129 - Looks good.

justgo129 commented 8 years ago

Merged #167.