USGCRP / gcis-ontology

Ontology for the Global Change Information System
4 stars 7 forks source link

Update run-tests.sh #170

Closed zednis closed 8 years ago

zednis commented 8 years ago

Changes to make to the ./run-tests.sh script invoked by Travis-CI

zednis commented 8 years ago

@justgo129 @rewolfe This is a pull request (not ready for merge) for the branch on which we can do updates to run-tests.sh

justgo129 commented 8 years ago

Sounds good. @zednis should we hold off on making changes to https://github.com/USGCRP/gcis-ontology/blob/master/gcis.ttl until after the tests are developed?

rewolfe commented 8 years ago

@justgo129 - Yes, hold off for now. -Robert

On Wed, Nov 4, 2015 at 8:54 AM, justgo129 notifications@github.com wrote:

Sounds good. @zednis https://github.com/zednis should we hold off on making changes to https://github.com/USGCRP/gcis-ontology/blob/master/gcis.ttl until after the tests are developed?

— Reply to this email directly or view it on GitHub https://github.com/USGCRP/gcis-ontology/pull/170#issuecomment-153725019.

Robert Wolfe, NASA GSFC @ USGCRP, o: 202-419-3470, m: 301-257-6966

justgo129 commented 8 years ago

Understood. Tabled #170.

zednis commented 8 years ago

@rewolfe Have the other updates to run-scripts.sh been implemented? If so, I think this pull request is ready to merge.

rewolfe commented 8 years ago

@zednis - I did a merge. I don't know why the results are not what l expected. On Nov 16, 2015 2:45 PM, "Stephan Zednik" notifications@github.com wrote:

@rewolfe https://github.com/rewolfe Have the other updates to run-scripts.sh been implemented? If so, I think this pull request is ready to merge.

— Reply to this email directly or view it on GitHub https://github.com/USGCRP/gcis-ontology/pull/170#issuecomment-157148326.

zednis commented 8 years ago

OK. Let's open a branch and discuss that. I think this pull request is ready to merge though. It's a one-liner right now that makes the diff call in run-tests.sh OS X compatible. I'll merge.

rewolfe commented 8 years ago

Woops, I see that this was a different change. Merge was okay. @zednis