USGS-CMG / stglib

Routines used by the USGS Coastal/Marine Hazards & Resources Program to process oceanographic time-series data
Other
16 stars 13 forks source link

Aqd agc slbins #145

Closed rbales-usgs closed 11 months ago

rbales-usgs commented 11 months ago

This PR includes 2 QAQC Aquadopp features in aqdutils:

  1. Filling transformed velocities (u,v,w) by an AGC threshold. I did not include filling beam velocities (vel1,vel2,vel3) in the is feature. From what I'm noticing, the beam velocities are always left unfilled.
  2. Filling additional surface bins if trim_method 'water level sl' is not sufficient and some surface velocities are still bad throughout dataset.

Let me know if you have any suggested changes to how I've written the code/naming of threshold attributes.

rbales-usgs commented 11 months ago

Dan,

All comments were addressed, and I just pushed the branch to github.

I Included velocity_agc_min and velocity_agc_max in the same def fill_agc. If you prefer them to be in separate defs, I can update that. Let me know of any other changes!

dnowacki-usgs commented 11 months ago

Closes #144