remove 'name: Pac' attribute from exo and dwave p1ac

USGS-CMG / stglib

Routines used by the USGS Coastal/Marine Hazards & Resources Program to process oceanographic time-series data

Other

16 stars 13 forks source link

remove 'name: Pac' attribute from exo and dwave p1ac #147

Closed rbales-usgs closed 11 months ago

rbales-usgs commented 11 months ago

As PR title states, changes have been made to exo.py and rsk/cdf2nc.py to remove 'name: Pac' in P_1ac variable attributes.

dnowacki-usgs commented 11 months ago

Thanks Bo. Could you update this PR to also include removing the two vestigial, commented-out lines in aqdutils.py that reference a "name" attribute? Lines 1222, 1236. It's just extra cruft that doesn't need to stay, and is related to removing "name" attrs

rbales-usgs commented 11 months ago

Hi Dan, I made the changes and pushed back up so the PR should be updated.

I rebased my local feature branch without thinking about how that would cause my remote branch to be out of sync. Caused a little bit of issues but I think I fixed it (via git pull origin P1ac_names).