USGS-CMG / usgs-cmg-portal

do_convert.sh
6 stars 13 forks source link

has a 6th column that can be used to populate metadata_link attribute #283

Closed emontgomery-usgs closed 6 years ago

kwilcox commented 6 years ago

You need to add a column name for the "metadata_link" and fix a missing quote on line 2.

kwilcox commented 6 years ago

See https://github.com/USGS-CMG/usgs-cmg-portal/pull/285

emontgomery-usgs commented 6 years ago

@kwilcox

Where is the version with the 6th column? here I only see 5 columns https://github.com/USGS-CMG/usgs-cmg-portal/blob/master/woods_hole_obs_data/project_metadata.csv. Is this a change made at Secora? Thanks!

kwilcox commented 6 years ago

Yup it was. I manually cleaned up your changes (there were missing quotes and a missing column header) and opened this as a replacement: #285.

emontgomery-usgs commented 6 years ago

@kwilcox - should we add the 6th column to the version at the link I sent (and the code I use to generate what goes on our portal)? Seems like it would be helpful. I thought I'd see 6 columns in the version on git-hub- but I only see 5, with the last comment being about changing the pointer to silt? do I need to pull or update to see 6 columns ? Thanks!

kwilcox commented 6 years ago

I just merged my PR and you should see it in the code now

emontgomery-usgs commented 6 years ago

Thank you, I see it now.