USGS-R / Rainmaker

Repo being permanently moved to: https://code.usgs.gov/water/analysis-tools/Rainmaker
https://code.usgs.gov/water/analysis-tools/Rainmaker
Other
18 stars 14 forks source link

Check RMEvents function start and end times against original rainmaker #8

Closed rbcarvin closed 6 years ago

rbcarvin commented 7 years ago

Need to check if current RMEvents function returns the same start and end times as original rainmaker. Furthermore, need to be sure the original rainmaker start and end times were being returned correctly.

rbcarvin commented 6 years ago

An 'error' or discussion about the 'correct' start time led to writing the RMevents function to subtract the minimum time step present in the raw rain data set from the time of the first tip. The assumption being it took that long for the rain to accumulate in the tipping bucket. This means the start and end times in the R RMevents function may not match the original rainmaker, and that is ok. RMEvents_sko was tested on 1/10/2018 with a test data set and it found the 'correct' start and end times.