search

USGS-R / WREG

Develops regional estimation equations for streamflow characteristics that can be applied at a ungaged basins.
8 stars 7 forks source link

Add Site numbers to all appropriate tables in WREG... functions #102

Open tjmills opened 8 years ago

tjmills commented 8 years ago

Site numbers should be included in all output of WREG functions as either a column in the case of a dataframe or row.names in the case of matrices.

All matrices should be converted to dataframes if possible.

This allows the user to easily do table joins on site number. Also, for exporting output to text files, users will want Site ids in the files.

tjmills commented 8 years ago

Also,

LevInf.Sig should have column names corresponding to the description in the WREG... function help.

Also, significance should be qualified in help text. Is this at p=0.05 ?

wfarmer-usgs commented 8 years ago

LevInf.Sig already has variable names, as a data.frame.

Significance for leverage and influence does not follow the 'p-value' methodology. Instead, the test statistics themselves were included.

tjmills commented 8 years ago

when I open the LevInf.Sig element of the output list from WREG there are no names to the columns nor are there site numbers.

I believe this was from running WREG.OLS

wfarmer-usgs commented 8 years ago

Site numbers in the WREG* functions are not available as they are not passed. WREG(MatLab) does not retain site numbers either. The WREG functions were written as generics. If we want to include site numbers, they should either be appended in a print function or included as additional arguments.

In my opinion, it is clear that the outputs follow the same ordering as the inputs, whether they be site numbers or not. For now, I think it should be left as is.

If you want to track site numbers through the GUI, feel free. Otherwise, I think it should be a (low-hanging) enhancement down the road.

wfarmer-usgs commented 8 years ago

Ah, found the bug on LevInf.Sig. Correcting now...