search

USGS-R / drb-estuary-salinity-ml

Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

Add lagged input #126

Closed galengorski closed 1 year ago

galengorski commented 1 year ago

This is a change to add lagged inputs as predictors to the model. The inputs that are lagged are discharge in the Delaware (discharge_01463500) and in the Schuylkill (discharge_01474500), they are lagged by 7 and 8 days, respectively. Those numbers are hard coded for now. The lagged variables are added in addition to the unlagged discharge.

The other change is to update the hyperparameters including, the number of replicates from 5 to 10.

jds485 commented 1 year ago

Looks good to merge. The approve button disappeared, so this is my approval

galengorski commented 1 year ago

Looks good to merge. The approve button disappeared, so this is my approval

Awesome thanks very much for the review!