search

USGS-R / drb-estuary-salinity-ml

Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

add usgs gap analysis #38

Closed amsnyder closed 2 years ago

amsnyder commented 2 years ago

Code to produce gap analysis plots for USGS NWIS data. This should be able to run on NOAA data produced by the munge step with just a few additions to the config.

amsnyder commented 2 years ago

I'm just going to merge this so I can make some more updates--it won't impact any of the scripts you are currently working with. Let me know if you want to make changes though, and I can make any needed updates!

amsnyder commented 2 years ago

For the first bullet point, I added one directory for plots and one for csvs. Let me know if that looks ok.

amsnyder commented 2 years ago

For the second bullet point, I am seeing a small fraction of data in 2021 for 01474500, and no data in 2021 for 01463500. Is this what you're seeing too?

I did update the percent coverage calculation because I was just dividing by 365 days to get the % before. Now I am dividing by the actual number of days in the year. And for the current year, I am dividing by the days that have elapsed so far, rather than how long the year will be.

amsnyder commented 2 years ago

For the third bullet point, I was losing gaps at the start and end of the year, and I've updated the code so those are not missed.

amsnyder commented 2 years ago

@galengorski - I think I've addressed your concerns, but please let me know if I've missed anything! Otherwise, I think I will merge this request.

galengorski commented 2 years ago

Thanks @amsnyder, this sound good to me, I'm not going to run it on my machine, but since it isn't connected to any other part of the pipeline we can merge it now and always revisit if we want to make changes.