update NOAA fetch/munge

USGS-R / drb-estuary-salinity-ml

Creative Commons Zero v1.0 Universal

0 stars 4 forks source link

update NOAA fetch/munge #53

Closed amsnyder closed 2 years ago

amsnyder commented 2 years ago

Updated code to:

fetch data month by month due to API request restrictions
fetch data for all NOAA sties
add conductivity to list of variables to fetch

I also switched to the mean sea level datum, as recommended by Salme.

amsnyder commented 2 years ago

@ted80810 - if these changes look ok, can i delete the current data files on S3 for NOAA to replace with these outputs? I don't want to remove anything on there that is important, but I'm not sure if any of the files need to stay!

ted80810 commented 2 years ago

@amsnyder You can go ahead and delete those outputs from S3. I appreciate you asking. I am still checking out the your updates locally. It looks good so far though.

galengorski commented 2 years ago

I just pulled this PR into a new branch on my local and tried to run it. It seemed to run fine and produce the correct files, but I got the following error. I am happy to try to track this down and debug, but I am trying to move forward with the analysis and don't want to get bogged down so I'll just leave it here for now and will return later. munge_error

amsnyder commented 2 years ago

I am going to merge this PR, but let's revisit this error