search

USGS-R / gsplot

plotting foundation for timeseries reporting
Other
6 stars 14 forks source link

trying another approach for custom grid #386

Closed jordansread closed 8 years ago

jordansread commented 8 years ago

384

jordansread commented 8 years ago

@lindsaycarr there is redundant code in here, but this was kind of what I had in mind

lindsayplatt commented 8 years ago

all the :+1: this is so much cleaner than what I was implementing (and I branched, so easy to delete!)

jordansread commented 8 years ago

Want to take this and streamline it (get rid of the redundancy and other stuff) and add your tests? Curious if it passes your new tests - I didn't try them.

lindsayplatt commented 8 years ago

Yes, I can do that. Should I make a branch of yours and do a pull request to your fork when ready?

jordansread commented 8 years ago

@lindsaycarr feel free to pull down this PR (e.g., git pull https://github.com/jread-usgs/gsplot.git view_filter) and do a new PR against that branch on my repo https://github.com/jread-usgs/gsplot/tree/view_filter

jordansread commented 8 years ago

@lindsaycarr got your's in here. I'll leave the merge up to you if you are 👍

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 77.338% when pulling c1ca5de5467b4050acba31ea64035b0a719f4725 on jread-usgs:view_filter into fd18d5ee08f7fa31e3afbeef77caf3cfd31deeff on USGS-R:master.