change order of print - Githubissues

USGS-R / gsplot

plotting foundation for timeseries reporting

Other

6 stars 14 forks source link

change order of print #390

Closed lindsayplatt closed 8 years ago

lindsayplatt commented 8 years ago

@jread-usgs review and merge?

coveralls commented 8 years ago

Coverage remained the same at 77.65% when pulling e90471592ef09c59566c93614b35866327f76d97 on lindsaycarr:master into 4e316124f2ff5575238a0b692439ee1bf96aa9c9 on USGS-R:master.

jordansread commented 8 years ago

@lindsaycarr can you run devtools::build_vignettes() and knit the readme as part of this PR? Just want to see what all it changes visually.

coveralls commented 8 years ago

Coverage remained the same at 77.65% when pulling 350e76282927dd52f2fa8ec0d722a17e0cdb6bb6 on lindsaycarr:master into 4e316124f2ff5575238a0b692439ee1bf96aa9c9 on USGS-R:master.

coveralls commented 8 years ago

Coverage remained the same at 77.65% when pulling 350e76282927dd52f2fa8ec0d722a17e0cdb6bb6 on lindsaycarr:master into 4e316124f2ff5575238a0b692439ee1bf96aa9c9 on USGS-R:master.

coveralls commented 8 years ago

Coverage decreased (-0.05%) to 77.601% when pulling aba7d54c537a7787e1bb96f09198a6b450571a16 on lindsaycarr:master into 4e316124f2ff5575238a0b692439ee1bf96aa9c9 on USGS-R:master.

jordansread commented 8 years ago

Looks like we still have an issue with the legend location? Or do you need to re-knit the vignettes?

lindsayplatt commented 8 years ago

I need to re-knit

lindsayplatt commented 8 years ago

Wanted to make sure changing par here wasn't too hacky before doing that

jordansread commented 8 years ago

I think this level of hacky-ness is on par with the existing function, so I don't see a problem. Eventually, we will want to overhaul how this is done to be more robust and fit with the other rendering pattern we are converging on.

lindsayplatt commented 8 years ago

@jread-usgs ok, but that won't affect gsplot stability since it is behind-the-scenes, correct? Hoping to release new version later this week

jordansread commented 8 years ago

correct

coveralls commented 8 years ago

Coverage increased (+0.04%) to 77.69% when pulling 00109c479d2e51f76ec37dc5921743992eb643d4 on lindsaycarr:master into 4e316124f2ff5575238a0b692439ee1bf96aa9c9 on USGS-R:master.

coveralls commented 8 years ago

Coverage increased (+0.04%) to 77.69% when pulling 00109c479d2e51f76ec37dc5921743992eb643d4 on lindsaycarr:master into 4e316124f2ff5575238a0b692439ee1bf96aa9c9 on USGS-R:master.