search

USGS-R / gsplot

plotting foundation for timeseries reporting
Other
6 stars 14 forks source link

Data frame #411

Closed jordansread closed 7 years ago

jordansread commented 7 years ago

for #322

jordansread commented 7 years ago

whoops, looks like there is something in the examples that isn't in tests.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 79.523% when pulling b3ac888f1fa41595b99448525bf5e2b7d6a5c58b on jread-usgs:data_frame into a83420be22628f12ad65f518c52dacdb34d087d8 on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 79.523% when pulling f6074e794be99af2de9703f6e60afde39e718020 on jread-usgs:data_frame into a83420be22628f12ad65f518c52dacdb34d087d8 on USGS-R:master.

ldecicco-USGS commented 7 years ago

Is this ready to merge?

jordansread commented 7 years ago

I think so..?

lindsayplatt commented 7 years ago

@jread-usgs looks like this broke axis labeling, but only seems to be for side 2 and 4:

gs <- gsplot() %>% points(1,2)
gs

image

jordansread commented 7 years ago

@lindsaycarr we should revert this then, right?

lindsayplatt commented 7 years ago

I'd say yes...how exactly do we do that?

jordansread commented 7 years ago

I don't know....Maybe that happened accidentally w a merge? Let's track down the commit and figure out why