search

USGS-R / gsplot

plotting foundation for timeseries reporting
Other
6 stars 14 forks source link

error_bar fix #428

Closed ldecicco-USGS closed 7 years ago

ldecicco-USGS commented 7 years ago

Is a start on #417

Still don't know what triggers a transparent background on my computer.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 81.087% when pulling 0f5130567fd9b1dbac63cf4d03880f0350679efa on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 81.087% when pulling 0f5130567fd9b1dbac63cf4d03880f0350679efa on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 81.087% when pulling 0f5130567fd9b1dbac63cf4d03880f0350679efa on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 81.087% when pulling 0f5130567fd9b1dbac63cf4d03880f0350679efa on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

jiwalker-usgs commented 7 years ago

We are back to transparent plots, which is right?

ldecicco-USGS commented 7 years ago

I'm trying to figure out the transparency thing. It might be the order on if I build the vignette first and then the readme.

lindsayplatt commented 7 years ago

If it's the order that is making the difference, then would that be a par resetting issue?

ldecicco-USGS commented 7 years ago

That's my theory, I haven't had time to check yet.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 81.087% when pulling da71c8c7f1f57202c01456f8b4b7bcac0670c592 on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 81.132% when pulling 92e466320809c53c84acfdff94ef164a0dd92009 on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

ldecicco-USGS commented 7 years ago

Building the vignette and looking at it, something looks amiss with layout, I'll have a look later. That might have nothing to do with this particular PR.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 81.132% when pulling efff7d0b5424674581054e17b0a2fc8b0e9c27c1 on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 81.132% when pulling efff7d0b5424674581054e17b0a2fc8b0e9c27c1 on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.4%) to 81.132% when pulling efff7d0b5424674581054e17b0a2fc8b0e9c27c1 on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.

ldecicco-USGS commented 7 years ago

I've confirmed the layout issue happened before this PR (I'm pretty sure it was on #424. So, who merged that without checking the vignette? Oh yeah, me....lesson learned). So, I added the the offending graph to the README so we can see it and fix it easier in the future.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 82.311% when pulling df4b98e12194a9a9ce5adb47dbd54335872c0d1b on ldecicco-USGS:master into 485bdabbee285e208f93e796722d2dfbb1ccb08c on USGS-R:master.