Closed ldecicco-USGS closed 7 years ago
Could you add examples of what the plots produced look like? Would be good to have that for future us.
This also might be related to #404
so in a nutshell, I wrote this Issue and submitted a PR not too long later to fix it. More importantly, I added the offending graph to the Readme, so we should be doubly sure to see if we break it next time (I'm befuddled on how/what to test in a unit test with layout
, but we will now see diff's of the readme figure). It was in the vignette, but github doesn't show a nice diff on those html files like it does with the plain ol' pngs.
(this works as expected with PR#431). With the current master:![image](https://cloud.githubusercontent.com/assets/1105215/22789809/d4fcdc08-eea9-11e6-80e5-71d266368d17.png)
and
With current master branch:![image](https://cloud.githubusercontent.com/assets/1105215/22789850/f27e6b7a-eea9-11e6-91e3-3ddc1c65385f.png)
(again, I think #431 fixes both of these....) with the pr: