search

USGS-R / gsplot

plotting foundation for timeseries reporting
Other
6 stars 14 forks source link

Rethink error_bar arguments #433

Closed ldecicco-USGS closed 7 years ago

ldecicco-USGS commented 7 years ago

"y.low seems like it's the low value for y, ie: the actual value where you place the low bar. i suppose you could keep y.low to mean that, and add another param if someone wanted to specify the error up/down (offsets)."

lindsayplatt commented 7 years ago

This is an easy fix if we do anything about it, so I am pulling it in. I think it needs to be done sooner rather than later, otherwise we just continue as we have it currently implemented. Let's discuss.

jordansread commented 7 years ago

Changing it now also makes it easier to add as an additional parameter that gets included in the limit calculation as mentioned in #442. If we keep as-is, we kind of need to transform/calculate the argument into something else to use it.

lindsayplatt commented 7 years ago

New arg names:

offsets: offset.up offset.down offset.left offset.right

Change arg names to the offset versions.