search

USGS-R / gsplot

plotting foundation for timeseries reporting
Other
6 stars 14 forks source link

Theme test fix #441

Closed ldecicco-USGS closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling acb55f16c8af5f16ba3831f26f1e649ad466974a on ldecicco-USGS:theme_test_fix into on USGS-R:master.

lindsayplatt commented 7 years ago

@ldecicco-USGS what am I testing here? Is there something specific I need to look for?

ldecicco-USGS commented 7 years ago

I got trigger happy on the PR #435 (it was approved to merge, but I pushed an extra commit that I forgot I pushed...). Anyway, that new commit broke a test, now I fixed that, and that's what this is. I'd say, if you want to just pull down this branch and see if this works on your computer, we should be good:

gs_packers <- gsplot(theme = theme.packers) %>%
  points(1:10, 1:10)
gs_packers
lindsayplatt commented 7 years ago

Is the documentation for the theme arg still accurate?

path to the file that will only be used for setting the gsplot theme in this one gsplot object.

It seems like there are many more options for theme than what it says: use a built-in theme by using the object name, create your own theme object and put that here, or put a path to a .Rdata file that specifies your theme. It would be nice to update that. But maybe that can go with a diff pr

ldecicco-USGS commented 7 years ago

You're right, documentation should be improved.

ldecicco-USGS commented 7 years ago

OK, updated the documentation. If it looks OK, go ahead and merge. Across the board, I think we need to work on our documentation, but that will be for milestone 0.9.0

lindsayplatt commented 7 years ago

Travis seems to be stuck again. I'm going to go ahead and merge since it passed the AppVeyor build