search

USGS-R / hazardItems

Services for creating coastal change hazards items for the USGS Coastal Change Hazards Portal
https://marine.usgs.gov/coastalchangehazardsportal
Other
4 stars 9 forks source link

Changes for real time storms functions #101

Closed mhines-usgs closed 8 years ago

mhines-usgs commented 8 years ago

The CCH team needs to support Noreasters/Winter storms so we have modified the service to allow for more than titles pertaining to Tropical Storms or Hurricanes.

In Sept 2015, the NOAA server which hosts the NHC tracks changed, so this PR also includes changes related to that.

mhines-usgs commented 8 years ago

@jiwalker-usgs yo, can you take a peek before I merge?

mhines-usgs commented 8 years ago

not sure why the travis CI failed, checking...

jiwalker-usgs commented 8 years ago

You probably want to up the version number in the DESCRIPTION as well.

mhines-usgs commented 8 years ago

@jiwalker-usgs good call, I'll do that (version number).

The Travis failure is related to the stupid BBOX thing we keep seeing. A test is failing apparently?

checking examples ... ERROR Running examples in ‘hazardItems-Ex.R’ failed The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")

Name: thumb.service

Title: create thumbnail for an item

Aliases: thumb.service

\ Examples

serviceEndpoint <- 'http://marine.usgs.gov/coastalchangehazardsportal/data/item/CAkR645' thumb.service(serviceEndpoint) Error in bboxes[j, ] <- unlist(item.json$bbox) : number of items to replace is not a multiple of replacement length Calls: thumb.service -> getUniqueBBoxIDs Execution halted

jordansread commented 8 years ago

tests work locally?

mhines-usgs commented 8 years ago

no @jread-usgs same issue.

mhines-usgs commented 8 years ago

Weird because we haven't changed anything related to the thumbservice...

jordansread commented 8 years ago

potentially some packages were updated between now and then.

mhines-usgs commented 8 years ago

on the server? aren't we fixing versions like AQCU?

jordansread commented 8 years ago

the server has manual (?) package installs, so you may be testing a different set of packages than exists on our rserve. travis and local are probably closest to the newest releases (travis will be completely current unless you get fancy w/ installs)

mhines-usgs commented 8 years ago

ah, right.. i think I can compare versions. Good point. So what fails on Travis doesn't necessarily mean we fail on the server... the last build passed and nothing changed since then, but you're right, likely the packages have...