search

USGS-R / lakeReport

Scripts and report generator
Other
0 stars 4 forks source link

Moved stage hydrograph title to accommodate several decimal places #71

Closed sbmarsh-USGS closed 7 years ago

sbmarsh-USGS commented 7 years ago

For plots with several decimal places on the y-axis, there won't be anymore overlap. This addresses part of the #67, but not all, as I'm still working on adjustments to the qwtimeseries labels.

lindsayplatt commented 7 years ago

Great!

There are two functions there for making the plot because of data from either the file or from NWISWeb via dataRetrieval. Unfortunately, I didn't have them share the same actual plot creation function so they both call gsplot, which means you have to make changes in multiple places. Kind of annoying and not good long term, so I made an issue for the future (see #72).

With that said, wouldn't you want them to both have the same code? In the first one, you eliminated the line= argument, but in the second you added it. It probably makes since to have them match. What do you think?