search

USGS-R / protoloads

Prototyping and exploring options for broad-scale load forecasting
0 stars 4 forks source link

Preds v time #60

Closed aappling-usgs closed 6 years ago

aappling-usgs commented 6 years ago

Formalized some exploratory code and updated this figure to include all of the nearly one year of output we now have. fig_preds_v_time

I also merged upstream from the most recent PR (@jzwart 's fig_input_data) and found that remake wanted to rebuild that file even though I thought that was unnecessary. There were two reasons:

  1. We were using remake_file='9_report.yml' as an argument to the figure recipes, which meant that every figure was rebuilding anytime we edited 9_report.yml in any way; to fix this for the future I've changed the argument to remake_file=I('9_report.yml').
  2. The hash of input_data_example.yml was different on my computer than it was on yours, @jzwart . I suspect this is a line ending thing. Does it help if you set your project options to Code Editing | Line Ending Conversion = Posix (LF), to match mine?
jzwart commented 6 years ago

Hmm... my line endings are already set to Posix (LF)

aappling-usgs commented 6 years ago

Welp...that's not it then. I wonder what's up. Do you have exactly this, with no trailing spaces and one empty line at the end? image

jzwart commented 6 years ago

yeah that's what I got image

aappling-usgs commented 6 years ago

Ohh, right, I remember - so git is pulling down text files for me using Windows line endings (CRLF). So even if your local file is LF right now, and regardless of your settings, I'm gonna get CRLF by the time I git pull from one of your commits. I just found this page today: https://help.github.com/articles/dealing-with-line-endings/. It's a bit beyond what I can do today to get it worked out (see especially the last bit about fixing your whole repo all at once), but would be cool if we could get that to work.

jzwart commented 6 years ago

Ah. Maybe we can overhaul once we get new data from Dave?

And does it makes sense to have scipiper automatically create the .gitattributes file for line endings so that it's created at the start of each new repo?

aappling-usgs commented 6 years ago

Both good ideas - overhaul when we get new data, add to scipiper once we figure it out :+1: