USGS-R / repgen

report generation in R
Creative Commons Zero v1.0 Universal
9 stars 19 forks source link

Adjust TSS and CORR to remark about delete corrections properly #850

Closed mhines-usgs closed 5 years ago

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 97.469% when pulling 55f34ccb7cea152a0d7d7c687c677b963c0e7e5f on mhines-usgs:AQCU-1773 into 7741365247d80b7a168ee102550bfcff78cb52f7 on USGS-R:master.

mhines-usgs commented 5 years ago

The model appears to have "excludeCorrections" in the json. https://github.com/USGS-CIDA/aqcu-uv-hydro-report/blob/761f4bb64350c8372f46daf88b96f5ad9309fec9/src/main/java/gov/usgs/aqcu/model/UvHydroReportMetadata.java#L19, So the json coming in has excludeCorrections:

"reportMetadata": { "primaryParameter": "Discharge.ft^3/s@01038000", "upchainParameter": "Gage height.ft@01038000", "firstStatDerivedLabel": "Discharge.ft^3/s.Mean@01038000", "requestingUser": "kmschoep", "excludeCorrections": "DeleteRegion", "excludeZeroNegative": false }

For Uvhydro this is the case, but for TSS & CORR the json look like "reportMetadata": { "requestParameters": { "excludedCorrections": [ "DeleteRegion", "AdjustableTrim", "Deviation" ], "primaryTimeseriesIdentifier": "510e3bfd379b41f6a73843d0ca51f8dc", "startDate": "2015-11-01", "endDate": "2015-12-01", "requestPeriod": {} },