pass python object as `model` instead of str to training routine

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems

Creative Commons Zero v1.0 Universal

21 stars 15 forks source link

pass python object as `model` instead of str to training routine #118

Closed jsadler2 closed 2 years ago

jsadler2 commented 3 years ago

Currently the train_model function accepts a str as the model_type argument: https://github.com/USGS-R/river-dl/blob/0c78af242ca03010080bc7e43ca97d17cef6eda8/river_dl/train.py#L30

then later the function uses that as a switch to instantiate the model python object. It would be easier and clearer to just pass the python object to the model in the first place.