search

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 15 forks source link

103 flexible input and output names #120

Closed jsadler2 closed 3 years ago

jsadler2 commented 3 years ago

making the pre/post processing more flexible. this PR makes it so you define the spatial_idx_name, time_idx_name and, in the preprocessing, the dist_idx_name (if applicable).

I also updated some of the unit tests. The data for those tests were also updated which is why there are 92 files changed. Most of those files do not need to be reviewed.

closes #103

jsadler2 commented 3 years ago

@SimonTopp or @janetrbarclay - would one of you be up for reviewing this? There's not a big rush on it, but I do think it'd be nice to get done before my paternity leave starts. That way I can answer questions, etc.

janetrbarclay commented 3 years ago

I'd be happy to review it.

Janet

Janet Barclay U.S. Geological Survey New England Water Science Center Connecticut Office 101 Pitkin St. East Hartford, CT 06108

Phone (office) 860 291-6763 Fax 860 291-6799 Email @.**@*.**@*.***> https://www.usgs.gov/staff-profiles/janet-barclay

From: Jeff Sadler @.> Sent: Tuesday, June 22, 2021 5:36 PM To: USGS-R/river-dl @.> Cc: Barclay, Janet R @.>; Mention @.> Subject: [EXTERNAL] Re: [USGS-R/river-dl] 103 flex io names (#120)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@SimonTopphttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSimonTopp&data=04%7C01%7Cjbarclay%40usgs.gov%7C6e6ba8093d8b4b0fc0c008d935c5e52f%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637599946332985674%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=iGn9UJf5ML%2FZ9ypiyt%2FiJW%2BOnalAiSkdze8af2WOVRQ%3D&reserved=0 or @janetrbarclayhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjanetrbarclay&data=04%7C01%7Cjbarclay%40usgs.gov%7C6e6ba8093d8b4b0fc0c008d935c5e52f%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637599946332995625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2Wxz5JjNWHeg6ljoD8OfXCEmAe6Y9Ly9awTTbq3HB8g%3D&reserved=0 - do you think one of you would be up for reviewing this? There's not a big rush on it, but I think it'd be nice to get done before my paternity leave starts. That way I can answer questions, etc.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSGS-R%2Friver-dl%2Fpull%2F120%23issuecomment-866351378&data=04%7C01%7Cjbarclay%40usgs.gov%7C6e6ba8093d8b4b0fc0c008d935c5e52f%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637599946332995625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JWJ4HveSwICEOCDjURRvTL1O9EvKJ%2FAurBnFDoRDNuI%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA5H7UATYKKEW7CUAAZMO2TTUD67BANCNFSM47EQJGNQ&data=04%7C01%7Cjbarclay%40usgs.gov%7C6e6ba8093d8b4b0fc0c008d935c5e52f%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637599946333005584%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4YvVcUokYKvRk2hLMtDOf9ktF3iJWGU4DoDVWuB%2Bb14%3D&reserved=0.

SimonTopp commented 3 years ago

@janetrbarclay I'm happy to as well if you get busy! Just let me know.

jsadler2 commented 3 years ago

@SimonTopp - could you take another look at this. I think I addressed all of your comments.