search

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 15 forks source link

Use all training dates for observed Ar and delta Phi #124

Closed janetrbarclay closed 3 years ago

janetrbarclay commented 3 years ago

This calculates the observed Ar and delta Phi (amplitude ratio and phase shift) using all training dates, not only those from the PRMS simulation. (which greatly increases the number of observations) This requires the assumption that the air temperature signal properties (phase and amplitude) from the PRMS period (WY 1981 - 2016) apply to the later training period (WY 2017-2020). For now we're assuming they are constant during the PRMS period, so it seems reasonable to also assume that they don't change much during the next couple years, but this could be something to look into in the future.

janetrbarclay commented 3 years ago

@jsadler2, @jzwart , @SimonTopp - could one of you take a quick look at this? (just a couple changed lines) Thanks!

SimonTopp commented 3 years ago

@janetrbarclay one minor comment, but feel free to merge!