USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 15 forks source link

Swapped out linear algebra GW loss term for FFT approach. #125

Closed SimonTopp closed 3 years ago

SimonTopp commented 3 years ago

Updated GW loss to use the FFT approach. One important distinction is that we now calculate the air phase and amplitude yearly within the loss function instead of beforehand in the data prep.

janetrbarclay commented 3 years ago

just adding a note to this conversation that Simon and I are working on debugging this. He can get it to work locally and on TG. I am getting errors on both pangeo and TG.

janetrbarclay commented 3 years ago

seems to be a cpu / gpu issue. the fft approach fails on the gpu's and runs correctly on cpu's