Closed SimonTopp closed 2 years ago
Thanks @janetrbarclay! The naming difference is intentional, I could imagine scenarios where you want the offset
and the keep_portion
to be different. For example, if you wanted to test how different lengths of look back periods impacted results, you would keep the same offset
but adjust the keep_portion
. Also, we call it keep_portion
for the predict arguments, so data prep is all offset
, and then everything that has to do with prediction is keep_portion
. Happy to chat more, but I'd vote to leave as is.
Caught some small errors in the code that masks out the non-keep portion in pretraining that was added in #154. Errors were missed because it was only tested with fine-tuning. We were calling
y_val_pre
even though there is no validation in pre-training, and we were callingy_trn_obs.shape
instead ofy_trn_pre.shape