Open jsadler2 opened 2 years ago
I did not include this in #148 because I'm not actually sure it belongs in this repo. In my understanding the partitions are narrower in spatial and variable-of-interest scope of river-dl
. I see the partitions applying only to the DRB and to water temperature. But river-dl
could be applied to a river network (or non-river network) anywhere and to any variable. So I'm actually in favor of either not stating those agreed-upon partitions in the river-dl documents OR doing it in a way that communicates that this is just one group's decision. Maybe it would go in it's own file like DRB_temp_partitions.md
so that we have it for reference, but we aren't suggesting that everyone use those splits.
I see what you're saying. This seems somewhat related to the "does all the work for a few people vs does some work for lots of people discussion". Given that we're generally moving towards the latter, I think I'm fine leaving it out since it only applies to a handful of folks. @janetrbarclay, what do you think? I'm good closing this issue if you agree.
I'm not sure where it should be (and agree that maybe the main readme isn't the place), but it does seem useful to document somewhere (other than in a string of emails :) ) the baseline conditions we're using. This seems especially useful as we start having others work on the various temperature projects.
This seems especially useful as we start having others work on the various temperature projects.
This was really helpful for me on the reservoir project - https://github.com/USGS-R/delaware-model-prep/blob/main/test_train_split/explanation_test_set.md. There's also some slides somewhere explaining why they chose the years (e.g., why they're discontinuous) that I can't find right now...
Are these the slides you're referencing? Train-test split in DRB - Google Slideshttps://docs.google.com/presentation/d/1zR0BV6aY5TmlASB4z3L-kNrJbKKvB7so0_MbyJILI0Q/edit#slide=id.p [https://lh3.googleusercontent.com/UTVINf2cauD4oOEsWCUIPuX5dlYrJJsz8UNXAmSzD1a6q1ZmdCa-BDvzMoAs6KeYylFtm-SOb5P_5g=w1200-h630-p]https://docs.google.com/presentation/d/1zR0BV6aY5TmlASB4z3L-kNrJbKKvB7so0_MbyJILI0Q/edit#slide=id.p Train-test split in DRBhttps://docs.google.com/presentation/d/1zR0BV6aY5TmlASB4z3L-kNrJbKKvB7so0_MbyJILI0Q/edit#slide=id.p Shared train/test splits in the Delaware River Basin 3/18/21 - 4/15/21 docs.google.com
Janet Barclay U.S. Geological Survey New England Water Science Center Connecticut Office 101 Pitkin St. East Hartford, CT 06108
Phone (office) 860 291-6763 Fax 860 291-6799 Email @.**@*.**@*.***> https://www.usgs.gov/staff-profiles/janet-barclay
From: Jeremy Diaz @.> Sent: Thursday, February 24, 2022 9:21 AM To: USGS-R/river-dl @.> Cc: Barclay, Janet R @.>; Mention @.> Subject: [EXTERNAL] Re: [USGS-R/river-dl] Explicitly state agreed upon DRB partitions (years, segments) in readme? (Issue #162)
This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.
This seems especially useful as we start having others work on the various temperature projects.
This was really helpful for me on the reservoir project - https://github.com/USGS-R/delaware-model-prep/blob/main/test_train_split/explanation_test_set.mdhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSGS-R%2Fdelaware-model-prep%2Fblob%2Fmain%2Ftest_train_split%2Fexplanation_test_set.md&data=04%7C01%7Cjbarclay%40usgs.gov%7C76af5c94f2cd4e3c389808d9f7a10c2b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813093333430055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rVRxlDm%2BDf9nkPNqcYBYo4%2FLBTnq7HQUWHkRF62KSdk%3D&reserved=0. There's also some slides somewhere explaining why they chose the years (e.g., why they're discontinuous) that I can't find right now...
— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSGS-R%2Friver-dl%2Fissues%2F162%23issuecomment-1049909081&data=04%7C01%7Cjbarclay%40usgs.gov%7C76af5c94f2cd4e3c389808d9f7a10c2b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813093333430055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=lBkzOUu5E1z%2FiwhfSCfX63ok2O38YndZoJifg1i3H%2Fs%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA5H7UGXGMWD3LVOOLFK5JTU4Y5INANCNFSM5MYWU23Q&data=04%7C01%7Cjbarclay%40usgs.gov%7C76af5c94f2cd4e3c389808d9f7a10c2b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813093333430055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1b%2Fn5roUhByBt48OYo9wa61h%2B81bV%2BGHYoSzo1580xM%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cjbarclay%40usgs.gov%7C76af5c94f2cd4e3c389808d9f7a10c2b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813093333430055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3OIm678gYeFHcOyYaTlsE%2BaRz5VSCexm0HTjp90nULc%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cjbarclay%40usgs.gov%7C76af5c94f2cd4e3c389808d9f7a10c2b%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813093333586276%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=an0GuH2NB5Dq2BoBAVGvDsX0cZeiB2ZfrVKrTA1deCc%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
Yep, those!
I keep an email from Alison with that link and the time partitions pinned in my inbox for easy reference. :)
Janet Barclay U.S. Geological Survey New England Water Science Center Connecticut Office 101 Pitkin St. East Hartford, CT 06108
Phone (office) 860 291-6763 Fax 860 291-6799 Email @.**@*.**@*.***> https://www.usgs.gov/staff-profiles/janet-barclay
From: Jeremy Diaz @.> Sent: Thursday, February 24, 2022 9:28 AM To: USGS-R/river-dl @.> Cc: Barclay, Janet R @.>; Mention @.> Subject: [EXTERNAL] Re: [USGS-R/river-dl] Explicitly state agreed upon DRB partitions (years, segments) in readme? (Issue #162)
This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.
Yep, those!
— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSGS-R%2Friver-dl%2Fissues%2F162%23issuecomment-1049915814&data=04%7C01%7Cjbarclay%40usgs.gov%7C8706e24ece944c43648308d9f7a1f96d%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813097313018054%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7vTg4CgzN56fZTIkv0q2fBKI9DZwNF2k3GodApMyAA8%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA5H7UCATQNB6BSN6A3EWHTU4Y6BTANCNFSM5MYWU23Q&data=04%7C01%7Cjbarclay%40usgs.gov%7C8706e24ece944c43648308d9f7a1f96d%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813097313018054%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HlHTb8N05vWu7iU6uYg2fQSl5ug1UVGji10KjBOSouU%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cjbarclay%40usgs.gov%7C8706e24ece944c43648308d9f7a1f96d%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813097313018054%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7b4C00Emsfc8%2F3mIDqJw3WqrFlmMh3bOQWcnRdlZftc%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cjbarclay%40usgs.gov%7C8706e24ece944c43648308d9f7a1f96d%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637813097313018054%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ZUMbGUk%2FzJVgvDCosdjFLwMZCHdNE7VIurfOPb5w8pk%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
Somewhere (maybe in the readme), we should explicitly state the baseline run conditions we've all agreed upon across projects (partition years, segments)
_Originally posted by @SimonTopp in https://github.com/USGS-R/river-dl/pull/148#discussion_r789703849_