search

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 14 forks source link

Pass partition ids/data as dictionary to combined metrics #184

Closed jsadler2 closed 2 years ago

jsadler2 commented 2 years ago

The combined_metrics function currently takes pred_train, pred_val, and pred_test. I think it would make more sense if it took a dictionary with the partition id (e.g., train) as the keys and the prediction data file as the value.

jsadler2 commented 2 years ago

That would greatly simplify combined_metrics because then the function would simply iterate through that dictionary.