search

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 14 forks source link

adding GW metric calculation method option #197

Closed janetrbarclay closed 2 years ago

janetrbarclay commented 2 years ago

This PR adds an option for the method of calculating the annual temperature metrics used in the GW loss function. The option can be changed within the config file. Options include:

'static' : the metrics do not vary across years and are calculated by partition and by reach using all available years with >= 300 temp observations

'batch': the metrics are calculated by batch for batches with >= 300 observations, for other batches on the same reaches (within the same partition) the average values for the reach are used

'high_data_batches': metrics are only calculated for batches with >= 300 observations

'low_data_years': metrics are calculated by batch but only retained for batches with < 300 observations (using the average across batches on that reach with >= 300 observations)

janetrbarclay commented 2 years ago

Thanks @SimonTopp! I agree that streamlining this would be useful (and that it should wait for now).