janetrbarclay
commented
1 year ago Thanks! Yes, I did do a test run and didn't have any issues. Thanks!
Janet
Janet Barclay U.S. Geological Survey New England Water Science Center Connecticut Office 101 Pitkin St. East Hartford, CT 06108
Phone (office) 860 291-6763 Fax 860 291-6799 Email @.**@*.**@*.***> https://www.usgs.gov/staff-profiles/janet-barclay
From: Simon Topp @.> Sent: Thursday, November 10, 2022 1:56 PM To: USGS-R/river-dl @.> Cc: Barclay, Janet R @.>; Author @.> Subject: [EXTERNAL] Re: [USGS-R/river-dl] Drop exclude_file parameters and functions (PR #208)
This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.
@SimonTopp approved this pull request.
Nice! Thanks for going through and pulling these all out. Removing over 100 lines of code that does nothing is 🔥 🔥 ! Did you do a model run to make sure nothing breaks/there aren't legacy references to exclude that were missed? Assuming so then feel free to merge!
— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUSGS-R%2Friver-dl%2Fpull%2F208%23pullrequestreview-1176332664&data=05%7C01%7Cjbarclay%40usgs.gov%7C96d163e4641c4c3d445408dac34d3f74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638037033809979508%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o%2BcfrCRPrqeCooLHxPKXhaRIykBLDB8GBwfzG2BmPsY%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA5H7UGU6LWATIL62BUUTSDWHVAMZANCNFSM6AAAAAARXPKKNU&data=05%7C01%7Cjbarclay%40usgs.gov%7C96d163e4641c4c3d445408dac34d3f74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638037033809979508%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fiajR%2BOqq%2F0XcOBZIEWUHQl26Gsau5k70DaKmtBFgC4%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>
This PR follows up on #98. Currently the code and example Snakemake files suggest that there is an option to specify a file of excluded segments, but the exclusion doesn't get propogated through the code / training (weights are set to 0 for excluded segments but the weights are not currently used in the training => excluding the segments does not actually exclude them). This PR removes the illusion of being able to specify an exclude file.