search

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 14 forks source link

adding comment re: temps < 1 and fft #210

Closed janetrbarclay closed 1 year ago

janetrbarclay commented 1 year ago

adding a comment to explain why we drop temperatures < 1 when calculating the amplitude ratio and delta phi with the linear regression and set temperatures < 1 to 1 when calculating with fft

janetrbarclay commented 1 year ago

@SimonTopp , Thanks! I don't have that script on github. I could clean it up and add it. Right now it uses a prepped datafile (prepped_withGW.npz) so it wouldn't be easily runnable by someone else unless they ran the two prep steps first. Still worth adding it? I could also put the script and the output graphs in a word doc?

SimonTopp commented 1 year ago

Not sure it really belongs here in river-dl proper, but I think if it can't be accessed it might not be worth mentioning the file name. Instead I'd just qualitatively say we experimented and this was the best approach.