search

USGS-R / river-dl

Deep learning model for predicting environmental variables on river systems
Creative Commons Zero v1.0 Universal
21 stars 15 forks source link

Match what is in the SDM paper #96

Open jsadler2 opened 3 years ago

jsadler2 commented 3 years ago

Xiaowei has a slightly different, simpler version of the RGCN in the SDM paper. I think this is more understandable and it'd be good to change to it: image image

SimonTopp commented 2 years ago

I believe this is implemented in the PyTorch version by @jdiaz4302. @jsadler2, do you think we should implement it in the TF version as well still?

jdiaz4302 commented 2 years ago

Yep, that's what going on here: https://github.com/USGS-R/river-dl/blob/main/river_dl/torch_models.py#L164-L165

That # note: self.A @ q_t could be taken out, I believe that's a development relic/reminder that I didn't remove; it doesn't add anything/act as an informative comment.