tests with travis - Githubissues

USGS-R / rloadest

USGS water science R functions for LOAD ESTimation of constituents in rivers and streams.

Other

20 stars 19 forks source link

tests with travis #27

Closed aappling-usgs closed 7 years ago

aappling-usgs commented 7 years ago

Goal: narrow in on the segfaults caused by calls to loadReg. These segfaults may be occurring in other packages depended on by rloadest, but it would be helpful to see them at this level as well.

Changes:

added testthat and a single test that calls loadReg
because current Travis is stopping at segfault somewhere within vignettes, try to modify .travis.yml so that it doesn't build vignettes

aappling-usgs commented 7 years ago

Well, Travis still doesn't make it all the way to tests, but it does report on more of the stylistic issues available through R CMD check before giving up. (I attribute this to the use of the environment variables in https://github.com/USGS-R/rloadest/pull/27/commits/3dcb08f083ddfe7983e489dec4cee3e6b354b973.) Also, Travis actually reports its build as a failure rather than going green, which I think makes sense because the examples don't run on Linux. @ldecicco-USGS , do you agree that this is an improvement?

ldecicco-USGS commented 7 years ago

yup. A few tests that show the fragility seem good