USGS-R / training-curriculum

5 stars 16 forks source link

lindsay tries some css changes for code chunk style #312

Closed lindsayplatt closed 7 years ago

lindsayplatt commented 7 years ago

This reflects R style much better than before. Only thing I cannot figure out is why some of the output lines are considered class hljs-title and some are hljs-comment. I'd like them to all be styled like comments, but can't just change the title color because that class corresponds to other spots that should be colored black. Would be happy to chat about this in person @mwernimont . Also, if you have a better color than #aa5146 that passes the 508 contrast rules please let me know :)

Example of code output styled as title and then below it, code output styled as comments.

image

mwernimont commented 7 years ago

@lindsaycarr Does Hugo have some sort of documentation? Are we just missing something that is making Hugo think our intended comments are supposed to be titles? Could be a simple HTML element that Hugo triggers to be titles or something simple like that.

lindsayplatt commented 7 years ago

They do have documentation - https://gohugo.io/documentation/ . I looked in the markdown and compared the lines that were treated as titles instead of comments to the ones correctly treated as comments. I didn't notice anything obviously different about them, but maybe you might?

lindsayplatt commented 7 years ago

@mwernimont I did it (but had to use !important again.....)

mwernimont commented 7 years ago

Hmmm....I'll play around with that a bit this morning, I think its just something we may have to do, but always worth trying to avoid.

mwernimont commented 7 years ago

So was able to get without !important's, just gonna merge this and make a PR with the fix.