USGS-R / wateRuse

Moved to: https://code.usgs.gov/water/water-use/wateruse
https://code.usgs.gov/water/water-use/wateruse
Creative Commons Zero v1.0 Universal
7 stars 11 forks source link

Enhancements to Time Series Graphs #149

Closed jshourds-usgs closed 6 years ago

jshourds-usgs commented 8 years ago

Time Series:

This was a great opportunity to look at 6 years of data for an element for all the Counties in one or multiple States.

1) The points were hard to see. When I tried to select a point, I got the following error when looking at multiple States.

image

2) When I choose the legend and toggled off the “Points”, I really like this graphic. When I tried to select a bar graph to see what site it was, nothing came up.

image

3) I would like to be able to toggle off and on Counties in the legend.

4) It was hard for me sometimes to differentiate the orange colors and compare County to County. I would like to be able to make a bar graph with one to multiple counties with the years right next to each other. May have to use hatching to differentiate year to year. I can’t really tell in the graphic below how the different “orange” counties compared to each other between 2005 and 2010.

image

ldecicco-USGS commented 8 years ago

@jshourds-usgs can you pull down the most recent changes and see if you think this issue can be closed?

jshourds-usgs commented 8 years ago

So here's the superweird thing, @ldecicco-USGS . I did a git pull upstream master today and it said everything was up to date even though I was on AL yesterday and you have done a ton of updates yesterday and today. Seems like I got nothing... yikes. Any one else run into the same issue?

I also updated all my installed packages and seems like everything stayed the same...

I have to resolve this soon (ie before our training next week)-- although as long as I can still use the shiny app, no one expects you to have made Kim's enhancements so quickly anyway... so maybe this is not a cause for stressing about right now...

ldecicco-USGS commented 8 years ago

I pushed it out to GRAN...so you should be seeing a slightly updated app if you do this:

install.packages("wateRuse", 
       repos=c("https://owi.usgs.gov/R",
                "https://cloud.r-project.org"))
library(wateRuse)
explore_wateRuse()

Let me know if you don't see a tweeked app.

As for your github issue?....not sure....what do you get when you run in the git shell:

git config -l
jshourds-usgs commented 8 years ago

Ah now I see an updated app-- thanks for the reminder!

as for my git config screen here is a screen rip of what I see:

my git config minus l

which seems okay to me-- not sure why I wouldn't be getting the updates you did yesterday... Thanks for your help!

jshourds-usgs commented 8 years ago

so after reviewing the updated version, Kim's changes were made. Yay, thanks @ldecicco-USGS . The only one I think you missed was the color scheme (and I think this is a comment elsewhere too)-- when you are plotting a lot of counties, it's virtually impossible to tell apart the greens or oranges or other colors as it's a scale of color spectrum. Kim suggested hatching to differentiate?

colors

ldecicco-USGS commented 8 years ago

Looks like your "upstream" is the same as your "origin". You need to change the upstream url to:

git@github.com:USGS-R/wateRuse.git

https://help.github.com/articles/changing-a-remote-s-url/

ldecicco-USGS commented 8 years ago

yeah, it's always going to be hard to get enough distinct colors...but now the hover should always work well, and you can zoom in to the data you are curious about.

jshourds-usgs commented 8 years ago

I agree it's going to be hard to find distinct colors with that many variables. The hatching was a great suggestion per Kim but perhaps not feasible. Zooming in is great as is the labels working now... Great add.

As for changing my upstream, not sure how they became equal. Not having a lot of luck there-- trying to follow the website you sent and entering: git remote set -url git@github.com:USGS-R/wateRuse.git and here's what I get back:

remote

Clearly, I'm doing something wrong as when I git config -l it's still the same and master=origin. Argh...

ldecicco-USGS commented 8 years ago

don't put a space between set and -url...just set-url

ldecicco-USGS commented 8 years ago

wait, that's not it....

git remote set-url upstream git@github.com:USGS-R/wateRuse.git
jshourds-usgs commented 8 years ago

Ahhhh thank you I didn't know where to put the word upstream

Wasn't clear on the webpage-- thanks so much Laura! All set now!

jshourds-usgs commented 8 years ago

Great, so now I don't have rights to that repository??? all sorts of fatal errors

fatal

I keep getting myself deeper and deeper into a pile of :hankey:

ldecicco-USGS commented 8 years ago

You probably need to add your SSH key on whatever computer you are using now to your github account.

https://help.github.com/articles/adding-a-new-ssh-key-to-your-github-account/

This is because the DOI made some new security certificate thingies, and now we have to use SSH (at the workshop, we used https).

jshourds-usgs commented 8 years ago

okay so I feel pretty helpless here. I checked for ssh keys and here's what I get not sure how to add them?

ssh

I also thought I went through this already when Gary and Rob did but I guess since my master and origin were the same, it didn't work??

grrmartin-USGS commented 8 years ago

Yes I'm confused about this SSH key. I have one created on github, but I don't think it is on my computer. How can I tell? (Every time I wamt to git pull or git push, it asks for my passphrase.)

Also, I have been unable to create a new project for wateRuse from scratch. Using the old instructions linking to https gives In the Cloning Repository popup window: " Cloning into 'wateRuse'... fatal: unable to access 'https://github.com/grrmartin-USGS/wateRuse.git/': SSL certificate problem: unable to get local issuer certificate

To create a new project, should I instead be linking to git@github.com/ grrmartin-USGS/wateRuse.git/ https://github.com/grrmartin-USGS/wateRuse.git/ ?

Thanks

-Gary

Gary Martin (grmartin@usgs.gov)

Hydrologist

U.S. Geological Survey

Kentucky Water Science Center

9818 Bluegrass Parkway

Louisville, Kentucky

40299-1906

(502) 609-1383 (cell)

(502) 493-1914 (phone)

(502) 493-1909 (fax)

On Fri, Oct 7, 2016 at 11:49 AM, jshourds-usgs notifications@github.com wrote:

okay so I feel pretty helpless here. I checked for ssh keys and here's what I get not sure how to add them?

[image: ssh] https://cloud.githubusercontent.com/assets/18489683/19196560/1679e74e-8c84-11e6-98f0-aa7e2f510f34.JPG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/USGS-R/wateRuse/issues/149#issuecomment-252288698, or mute the thread https://github.com/notifications/unsubscribe-auth/ARkrJdzTzo2vxT7HG4vVEk26niwUYUyeks5qxmoSgaJpZM4KNBt5 .

ldecicco-USGS commented 8 years ago

Here's how you check for your existing SSH key:

https://help.github.com/articles/checking-for-existing-ssh-keys/

@grrmartin-USGS : you have to change your remote to the SSH remote instead of the https remote (again, this is because of DOI's newer policy... we took a short-cut using https at the workshop and now it's biting us in the butt).

Look above at the instructions for @jshourds-usgs :

It's probably:

git remote set-url upstream git@github.com:USGS-R/wateRuse.git
git remote set-url origin git@github.com:grrmartin-USGS/wateRuse.git
mamaupin-usgs commented 8 years ago

Does this need to be conveyed to the RWUS for training next week?

On Fri, Oct 7, 2016 at 10:28 AM, Laura DeCicco notifications@github.com wrote:

Here's how you check for your existing SSH key:

https://help.github.com/articles/checking-for-existing-ssh-keys/

@grrmartin-USGS https://github.com/grrmartin-USGS : you have to change your remote to the SSH remote instead of the https remote (again, this is because of DOI's newer policy... we took a short-cut using https at the workshop and now it's biting us in the butt).

Look above at the instructions for @jshourds-usgs https://github.com/jshourds-usgs :

It's probably:

git remote set-url upstream git@github.com:USGS-R/wateRuse.git git remote set-url origin git@github.com:grrmartin-USGS/wateRuse.git

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/USGS-R/wateRuse/issues/149#issuecomment-252298242, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyLb3wG4WKD6lm4agBO7TelP7tokRT3ks5qxnMogaJpZM4KNBt5 .

Molly A. Maupin Hydrologist USGS Idaho Water Science Center 230 Collins Road Boise, ID 83702

Office: (208) 387-1307 Fax: (208) 387-1372

mamaupin@usgs.gov

ldecicco-USGS commented 8 years ago

I would hope that "regular old users" aren't using the devtools or github (except to report issues). They should only use:

#only do this next line ONCE!!!!!
install.packages("wateRuse", repos = c("https://owi.usgs.gov/R","https://cloud.r-project.org"))

library(wateRuse)
explore_wateRuse()

github and SSH keys and devtools should only be for the developers of the package...ie anyone who went to the workshop. If someone new wants to start contributing to the code, then we can walk them through all that.

ldecicco-USGS commented 8 years ago

and, I'd prefer the new users follow the instructions on the readme (adding GRAN to their profile), and just click the update button vs what I pasted above.

mamaupin-usgs commented 8 years ago

thank you, I'm relieved.

On Fri, Oct 7, 2016 at 11:50 AM, Laura DeCicco notifications@github.com wrote:

and, I'd prefer the new users follow the instructions on the readme (adding GRAN to their profile), and just click the update button vs what I pasted above.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/USGS-R/wateRuse/issues/149#issuecomment-252317262, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyLb2FSn4gU3zZNa_cucjuBOAwg4EHnks5qxoZYgaJpZM4KNBt5 .

Molly A. Maupin Hydrologist USGS Idaho Water Science Center 230 Collins Road Boise, ID 83702

Office: (208) 387-1307 Fax: (208) 387-1372

mamaupin@usgs.gov

grrmartin-USGS commented 8 years ago

I created a new project linking to my fork at git@github.com:grrmartin-USGS/wateRuse.git (with Open in new window checked). However, the usual commands used in the git shell to push/pull don't work now. I can pull and push with the button/arrows though. Any idea why the shell would work differently with SSH?

I have the SSH key and upstream and origin established:

[image: Inline image 1]

On Fri, Oct 7, 2016 at 1:54 PM, Molly Maupin notifications@github.com wrote:

thank you, I'm relieved.

On Fri, Oct 7, 2016 at 11:50 AM, Laura DeCicco notifications@github.com wrote:

and, I'd prefer the new users follow the instructions on the readme (adding GRAN to their profile), and just click the update button vs what I pasted above.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/USGS-R/wateRuse/issues/149#issuecomment-252317262, or mute the thread https://github.com/notifications/unsubscribe-auth/ARyLb2FSn4gU3zZNa_ cucjuBOAwg4EHnks5qxoZYgaJpZM4KNBt5 .

Molly A. Maupin Hydrologist USGS Idaho Water Science Center 230 Collins Road Boise, ID 83702

Office: (208) 387-1307 Fax: (208) 387-1372

mamaupin@usgs.gov

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/USGS-R/wateRuse/issues/149#issuecomment-252318264, or mute the thread https://github.com/notifications/unsubscribe-auth/ARkrJfe3XPZ-e81JidYQi6go2Gqtpbvnks5qxodLgaJpZM4KNBt5 .

jshourds-usgs commented 8 years ago

okay so once I have checked my SSH key then I do what?

here is what I get when I check my SSH key:

ssh

jshourds-usgs commented 8 years ago

@mamaupin-usgs not only do the RWUSes not have to worry about this, I can still run what I need to run for the training despite not being able to get the pull request updates and being "fatal" over here in NJ! ;-) Thank goodness for that too!!

jshourds-usgs commented 8 years ago

Now I'm here: [https://help.github.com/articles/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent/#adding-your-ssh-key-to-the-ssh-agent] at step 2 that says:

Add your SSH key to the ssh-agent. If you used an existing SSH key rather than generating a new SSH key, you'll need to replace id_rsa in the command with the name of your existing private key file.

Sooo the question is how do I know what the name of my existing private key file is?? I tried replacing the id_rsa with my 4 digit # and then I went into the setting up on my profile to get that long jibber jabber key (the one with all the 2 digit alpha numerics and the colons) and neither worked...

ldecicco-USGS commented 8 years ago

I don't know...we might have to talk this through a webex next week.

jshourds-usgs commented 8 years ago

Ironically, I can get updates and all works well using gov equipment at home, logging in via SecurePulse. No need for passcode either. That equipment must not be up to DOI's new specs?

jshourds-usgs commented 7 years ago

Hi Laura @ldecicco-USGS ,

When you have a chance, can you help me deal with this? I am locked out from getting any updates via git shell and I think I need to get this resolved to be of any use to the team. This all started last fall when DOI changed the security requirements.

Here's what I get when I try a git pull upstream master :

gitpullprob2

Thanks so much! Jen