search

USGS-VIZLAB / how-to-gdp

Explanation of how the Geo Data Portal works.
Creative Commons Zero v1.0 Universal
1 stars 4 forks source link

figcaption same width as figures #61

Closed mwernimont closed 6 years ago

mwernimont commented 6 years ago

screen shot 2018-03-12 at 9 05 36 am screen shot 2018-03-12 at 9 05 44 am

Hows this look @lindsaycarr ?

mwernimont commented 6 years ago

@lindsaycarr Thought about it and came up with a better solution. I put a div around the img and figcaption and gave it a max-width of 503px (the size of the largest image we have in a figure tag.) That way instead of creating a hard-coded width for the figure caption text, it dynamically adjusts per figure depending on its size, which gets a cleaner line up of the text and figure.

Also, I removed the .gdp-flex from the single figures, as the flex is for lining up 2 or more figures together on one line.

lindsayplatt commented 6 years ago

🎉 woo! looks great! The mobile fixes are completely separate, right?

mwernimont commented 6 years ago

Yep, haven't started on those since I have other sprint work and you said it wasn't a priority right now.

mwernimont commented 6 years ago

But let me know if that changes.

lindsayplatt commented 6 years ago

Not a priority, just wondering!