search

USGS-VIZLAB / vizlab

Package with utilities for building vizlab pages
Creative Commons Zero v1.0 Universal
25 stars 14 forks source link

regain/identify expertise in svginject@vizlab #373

Open aappling-usgs opened 6 years ago

aappling-usgs commented 6 years ago

Jordan Walker resolved use the svginject javascript library (#187), but we have this warning in water-use-15:

In publish.svg(viz) :
  inline option is deprecated, all SVGs now use svg-inject

suggesting that we're not making use of Jordan's work. We need to identify a current team member who knows about this and can watch for it and consult the team on the use of svginject. if that expertise already exists then we just need to know who has it, otherwise, someone should go figure this out to become our expert.

jordansread commented 6 years ago

Is this potentially happening w/ the svg in the header? Or other small svgs that would be doing the same.

In the header:

<img class="vizlab-landscape vizlab-portrait" src="images/usgsLogo.svg" title="U.S. Geological Survey" alt="U.S. Geological Survey">
aappling-usgs commented 6 years ago

What do you mean by "this"?

jordansread commented 6 years ago

the warning = this.

aappling-usgs commented 6 years ago

ah. could be, i think we need someone to investigate. to me this is not a priority for water-use-15, though, so timing of addressing this issue should be vizlab timing, not water use viz timing.

ldecicco-USGS commented 6 years ago

I just added:

svg-injector-js: lib-svg-injector-js

to the viz.yaml in water-use-15 (and then put svg-injector-js) in the resources and the warning went away. That's all that I'm aware that we did in the hurricane viz's.

I'm not sure if we need to do some benchmarking to see if that helps or not. I have zero idea how svg-inject plays with D3.