new image element for yaml

USGS-VIZLAB / vizlab

Package with utilities for building vizlab pages

Creative Commons Zero v1.0 Universal

25 stars 14 forks source link

new image element for yaml #377

Closed mwernimont closed 6 years ago

mwernimont commented 6 years ago

For lazy loading I needed a new yaml element to allow a data-src image element to let us swap in images when they come into the viewport. With the help of @lindsaycarr was able to make that happen.

Lindsay I also had to switch srcset to data-src for the functionality to work properly.

jordansread commented 6 years ago

do we need to increase the vizlab version number for this?

lindsayplatt commented 6 years ago

Yes, that's a good point - we need to be able to reference it in water-use-15.

lindsayplatt commented 6 years ago

Ran local check, and worked:

* DONE
Status: 1 WARNING, 1 NOTE

See
  'D:/LRCData/R/vizlab.Rcheck/00check.log'
for details.

checking dependencies in R code ... NOTE
Unexported objects imported by ':::' calls:
  'remake:::assert_character' 'remake:::assert_has_targets'
  'remake:::remake' 'remake:::remake_print_message'
  See the note in ?`:::` about the use of this operator.
R CMD check results
0 errors | 0 warnings | 1 note 

R CMD check succeeded