search

USGS-VIZLAB / vizlab

Package with utilities for building vizlab pages
Creative Commons Zero v1.0 Universal
25 stars 14 forks source link

Footer contrast #379

Closed aappling-usgs closed 6 years ago

aappling-usgs commented 6 years ago

adding background:#414042; to footer a{} css element to satisfy 508 contrast error about text links in footer (regular-view contrast looks fine, but contrast would fail if a browser displayed the page without some visual elements)

This change is required to fully resolve 508 errors as in https://github.com/USGS-VIZLAB/water-use-15/pull/351

aappling-usgs commented 6 years ago

Getting the usual errors on Travis:

Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  any(grepl("microplastics", index)) isn't true.

  ── 5. Failure: publishLandingPage works (@tests-publishLandingPage.R#18)  ──────
  any(grepl("climate-change-walleye-bass", index)) isn't true.

  ══ testthat results  ═══════════════════════════════════════════════════════════
  OK: 125 SKIPPED: 2 FAILED: 5
  1. Failure: publish footer works (@tests-publish.R#29) 
  2. Failure: publish footer works (@tests-publish.R#31) 
  3. Failure: publish footer works (@tests-publish.R#42) 
  4. Failure: publishLandingPage works (@tests-publishLandingPage.R#17) 
  5. Failure: publishLandingPage works (@tests-publishLandingPage.R#18)