search

USGS-WiM / SC-RunoffModelingServices

Runoff Modeling for South Carolina StreamStats Phase II
Other
0 stars 0 forks source link

weightedcurvenumber add AEP #86

Closed harper-wavra closed 1 year ago

harper-wavra commented 1 year ago

In the weightedcurvenumber endpoint there should be an option to select AEP. You want to use the CN, S and Ia from that selected AEP.

It is currently just taking the 10% values.

See the Area Weighted/Runoff CN calculator sheets along with the WS & UH Data & Runoff Results sheet.

amedenblik commented 1 year ago

Related to #56

amedenblik commented 1 year ago

I reviewed the spreadsheets and the existing code. The code is working correctly as-is. The weightedCurveNumber function intakes value P24hr, which is the "24-hour Rainfall Depth (P), in inches; comes from rainfallData function for corresponding AEP". So the AEP is being accounted for already.

I remember now that I had discovered the error (where it was just taking the 10% values) in the first spreadsheet, and reported it to Tom/DOP. That's when they shared the second spreadsheet, which fixed the error. The third spreadsheet also has the error fixed.

Case closed, I think! Please reopen the issue if you think we need to look into this further.