Fixes #1707 Gageplots Feedback - Annual Peak Streamflow plot

[maggiejaenicke]

Closes #1707

[maggiejaenicke]

• Sometimes the log scale is not an option, image. I could not remember if we had talked about this, so maybe this is by design?

Similar to how the heat map determines if it should use log or linear, the log scale check box is only available if the data values do not contain any negative values (which causes the log option not to work on Highcharts). I have it set to not show the checkbox at all in this case (ng-if="vm.containsNegatives() === false"), but maybe it would be better/more self-explanatory if it were grayed out and still visible?

• After editing the time period shown on the plot, then clicking 'reset zoom' the page would sometimes freeze for me. This happened the most at gage 1234000. Not sure how easy this will be to fix, so could always make a separate issue.

12340000 seems to be super slow for a lot of things, and I think that is because of the huge data gap in the daily value data. The way that gap works is all the values are looped through so that each day has a data row and days without data get a null value. It does have to loop through a lot of data but I don't really know why it's soooo slow. I added some context about this to this issue, so maybe we can work on address loading issues all at once.

[maggiejaenicke]

Notes to self:

• [x] On gage 03132000, I am not seeing labels for any of the the horizontal streamgage statistics lines:

I think I could just set this up in a function similar to updateShadedStats() or updatePeaksAfterZoom() to update the endpoints of the flood stats lines whenever the axis is resized. Would need this to apply to all of the flood stats, even the ones not currently shown, so that if they are switched in the dropdown, they have the right endpoints.

[amedenblik]

Deployed to https://dev.streamstats.usgs.gov/gageplots/