fixes #47, sends null if global parameter computation fails

USGS-WiM / StreamStatsServices

StreamStats REST Services

https://streamstats.usgs.gov/streamstatsservices

Other

1 stars 0 forks source link

fixes #47, sends null if global parameter computation fails #48

Closed kjacobsen16 closed 3 years ago

kjacobsen16 commented 3 years ago

replicated the AttributesFromWorkspace.py to get parameters from the watershed's attribute table instead of reading the parameter.xml
when the watershed is global and a global parameter fails, send back null rather than the local value

Note: this is live on test, you can see 42.970681 -72.486822 in vermont has a couple failing characteristics (LC11DEV and LC11IMP)

kjacobsen16 commented 3 years ago

@jknewson alright I think I got them all switched to a single _, it's live on test/staging now and appears to be working well.

Kitty noticed the rounding was a bit weird, and turns out the attribute table doesn't have the correct rounding from the xml, so instead of taking all the global values from the attribute table, I'm just sending it as null/None if the global didn't compute and taking it from the parameter.xml otherwise. It looks like it takes the global if both compute.