When running the integration test we found an issue with the simplified basin parameter. The dist folder on the old test server had a dist folder where the simplify wasn't working, but pulling from the staging branch in github, we got a dist folder where the simplify was working. Before this it was thought that simplify wasn't working and was an outdated url parameter.
We'll have to figure out if
(a) the simplify was fixed and the dist folder was uploaded to github but not the server or
(b) the project was updated and broke the simplify and the dist folder was updated on the server but not on github.
If (a), we'll want to change the simplify to be false on default, update the documentation, and update StreamStats (I see the config says simplify=true even though we do the simplification in the client instead of the services, so we'll want to change that to false).
If (b), we'll want to talk with Pete about whether we want to have the simplify available in the services or not. The only reason we would is in case other users (who called our services directly) would find the simplified basins useful. If not, we could leave it broken/remove the functionality.
One thing to note is the streamstatsservices are really difficult to update so we'll have to gage how difficult it would be to update and if it's worth it. I haven't actually had to update the actual services part, just the python files. These would likely be actual service endpoint changes.
harper-wavra
commented
1 year ago
When running the integration test we found an issue with the simplified basin parameter. The dist folder on the old test server had a dist folder where the simplify wasn't working, but pulling from the staging branch in github, we got a dist folder where the simplify was working. Before this it was thought that simplify wasn't working and was an outdated url parameter.
We'll have to figure out if (a) the simplify was fixed and the dist folder was uploaded to github but not the server or (b) the project was updated and broke the simplify and the dist folder was updated on the server but not on github.
If (a), we'll want to change the simplify to be false on default, update the documentation, and update StreamStats (I see the config says simplify=true even though we do the simplification in the client instead of the services, so we'll want to change that to false).
If (b), we'll want to talk with Pete about whether we want to have the simplify available in the services or not. The only reason we would is in case other users (who called our services directly) would find the simplified basins useful. If not, we could leave it broken/remove the functionality. One thing to note is the streamstatsservices are really difficult to update so we'll have to gage how difficult it would be to update and if it's worth it. I haven't actually had to update the actual services part, just the python files. These would likely be actual service endpoint changes.